feat!: align flag names with lean-quickstart spec by conache · Pull Request #321 · lambdaclass/ethlambda

conache · 2026-04-28T18:09:30Z

Summary

Closes #287. Aligns CLI flags with the lean-quickstart spec.

Removed:

--custom-network-config-dir

Added:

Flag	Maps to
`--genesis`	`config.yaml`
`--validators`	`annotated_validators.yaml`
`--bootnodes`	`nodes.yaml`
`--validator-config`	`validator-config.yaml`
`--hash-sig-keys-dir`	`hash-sig-keys/`

--genesis, --validators, and --bootnodes are mandated by the spec.
--validator-config and --hash-sig-keys-dir cover ethlambda-internal paths that the spec doesn't standardize.

Coordination

Coordinated lean-quickstart PR: #321.

Testing

To verify the new flags locally:

Build the binary from this branch:
```
cargo build --release
```
Inspect --help and confirm the new flags appear:

./target/release/ethlambda --help

Flags that should be listed as part of the change: --genesis, --validators, --bootnodes, --validator-config, and --hash-sig-keys-dir
--custom-network-config-dir should no longer be present

To boot the binary from the lean-quickstart repository:

Checkout the ethlambda-update-cmd-flags branch associated with the lean-quickstart PR.
Run NETWORK_DIR=local-devnet ./spin-node.sh --node ethlambda_0 --generateGenesis

The binary parses succesfully parses all five flags.

Important note:

Unrelated to this PR; worth flagging as a separate issue if not already tracked.

Local-devnet boot panics after parsing the CLI flags with the following error (confirmed it reproduces identically on main):

thread 'main' (13480983) panicked at bin/ethlambda/src/main.rs:136:47:
Failed to parse config.yaml: Error("GENESIS_VALIDATORS[0]: invalid type: string \"...", expected struct GenesisValidatorEntry", line: 12, column: 7)

greptile-apps · 2026-04-29T13:09:51Z

Greptile Summary

This PR replaces the single --custom-network-config-dir flag with five explicit path flags (--genesis, --validators, --bootnodes, --validator-config, --hash-sig-keys-dir) to align with the lean-quickstart spec. All changed documentation and the devnet reference guide are updated consistently.

P1 — preview-config.nix was not updated: line 93 still passes --custom-network-config-dir genesisDir; the new binary will reject this unknown flag and all four Nix-managed node services will fail to start.

Confidence Score: 3/5

Not safe to merge until preview-config.nix is updated — all Nix node services will fail to start with the new binary.

One P1 defect: preview-config.nix still references the removed --custom-network-config-dir flag, which will cause immediate startup failure for Nix-managed nodes. All other changed files are correct. P1 caps the score at 4, and the affected path is a concrete production entrypoint, pulling the score to 3.

preview-config.nix — needs the five new flags in place of --custom-network-config-dir

Important Files Changed

Filename	Overview
bin/ethlambda/src/main.rs	Replaces single `--custom-network-config-dir` flag with five explicit path flags; mapping logic and error handling are correct and consistent with previous behavior.
.claude/skills/devnet-runner/references/long-lived-devnet.md	All five `docker run` invocations (initial start + rolling-restart template) updated to the new flags consistently.
docs/checkpoint_sync.md	Example command updated correctly to use the five new flags; prose updated to remove the old flag reference.
docs/fork_choice_visualization.md	Example `cargo run` command updated correctly to use the five new flags.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    CLI["CLI Argument Parsing\n(clap::Parser)"]
    CLI -->|"--genesis"| GP["options.genesis\n→ config_path\n(GenesisConfig)"]
    CLI -->|"--validators"| VP["options.validators\n→ validators_path\n(annotated_validators.yaml)"]
    CLI -->|"--bootnodes"| BP["options.bootnodes\n→ bootnodes_path\n(nodes.yaml)"]
    CLI -->|"--validator-config"| VC["options.validator_config\n→ validator_config\n(validator-config.yaml)"]
    CLI -->|"--hash-sig-keys-dir"| KD["options.hash_sig_keys_dir\n→ validator_keys_dir\n(hash-sig-keys/)"]
    GP --> GC["parse GenesisConfig\n(serde_yaml_ng)"]
    BP --> RB["read_bootnodes()"]
    VC --> PR["populate_name_registry()"]
    VP --> RV["read_validator_keys()"]
    KD --> RV
    GC --> FS["fetch_initial_state()"]
    RB --> SW["build_swarm()"]
    RV --> BC["BlockChain::spawn()"]
    FS --> BC

Comments Outside Diff (1)

preview-config.nix, line 93 (link)

Stale flag reference will break Nix node service

preview-config.nix still passes --custom-network-config-dir genesisDir to the binary. The new binary no longer recognizes this flag; clap will exit with an "unexpected argument" error, preventing all four Nix-managed node services from starting. The five replacement flags (--genesis, --validators, --bootnodes, --validator-config, --hash-sig-keys-dir) each expect a full file/directory path derived from genesisDir.

Prompt To Fix With AI

This is a comment left during a code review.
Path: preview-config.nix
Line: 93

Comment:
**Stale flag reference will break Nix node service**

`preview-config.nix` still passes `--custom-network-config-dir genesisDir` to the binary. The new binary no longer recognizes this flag; clap will exit with an "unexpected argument" error, preventing all four Nix-managed node services from starting. The five replacement flags (`--genesis`, `--validators`, `--bootnodes`, `--validator-config`, `--hash-sig-keys-dir`) each expect a full file/directory path derived from `genesisDir`.

How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: preview-config.nix
Line: 93

Comment:
**Stale flag reference will break Nix node service**

`preview-config.nix` still passes `--custom-network-config-dir genesisDir` to the binary. The new binary no longer recognizes this flag; clap will exit with an "unexpected argument" error, preventing all four Nix-managed node services from starting. The five replacement flags (`--genesis`, `--validators`, `--bootnodes`, `--validator-config`, `--hash-sig-keys-dir`) each expect a full file/directory path derived from `genesisDir`.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into add-spec-compli..." | Re-trigger Greptile}

conache added 5 commits April 28, 2026 20:09

Update flag names to match spec

e3410ab

Align cli flags with lean-quickstart spec

a4d6faf

Update docs based on the client flags updates

8be8cd8

Update claude skill with the latest details

b130fa6

Tweak flag comments

f3ee38d

conache marked this pull request as ready for review April 29, 2026 13:06

Merge branch 'main' into add-spec-compliant-flag-names

1cf082f

conache marked this pull request as draft April 29, 2026 13:07

conache marked this pull request as ready for review April 29, 2026 13:07

conache mentioned this pull request Apr 29, 2026

Update ethlambda CLI flags to align with the spec blockblaz/lean-quickstart#168

Draft

ci: update preview-config.nix to use the updated CLI flags

9a80e40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: align flag names with lean-quickstart spec#321

feat!: align flag names with lean-quickstart spec#321
conache wants to merge 7 commits intolambdaclass:mainfrom
conache:add-spec-compliant-flag-names

conache commented Apr 28, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Apr 29, 2026 •

edited

Loading

Important Files Changed

Comments Outside Diff (1)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

conache commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Coordination

Testing

Important note:

Uh oh!

greptile-apps Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Flowchart

Comments Outside Diff (1)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

conache commented Apr 28, 2026 •

edited

Loading

greptile-apps Bot commented Apr 29, 2026 •

edited

Loading